Ck/12077 mixins #12140
Merged
Ck/12077 mixins #12140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
approved these changes
Jul 26, 2022
niegowski
reviewed
Jul 27, 2022
Comment on lines
-87
to
-103
| /** | ||
| * Stops listening for events. It can be used at different levels: | ||
| * It is backwards compatible with {@link module:utils/emittermixin~EmitterMixin#listenTo}. | ||
| * | ||
| * * To stop listening to a specific callback. | ||
| * * To stop listening to a specific event. | ||
| * * To stop listening to all events fired by a specific object. | ||
| * * To stop listening to all events fired by all object. | ||
| * | ||
| * @param {module:utils/emittermixin~Emitter|Node|Window} [emitter] The object to stop listening to. | ||
| * If omitted, stops it for all objects. | ||
| * @param {String} [event] (Requires the `emitter`) The name of the event to stop listening to. If omitted, stops it | ||
| * for all events from `emitter`. | ||
| * @param {Function} [callback] (Requires the `event`) The function to be removed from the call list for the given | ||
| * `event`. | ||
| */ | ||
| stopListening( |
There was a problem hiding this comment.
This should probably not get lost and be moved to the interface method same as the above method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (utils): Introduces new way to apply mixins. Instead of using
mix()util, classes should extend the base created byEmitterMixin(),ObservableMixin()andDomEmitterMixin()or extendEmitterorObservabledirectly. Closes #12077.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.